Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the docs #7

Closed
yanokwa opened this issue May 7, 2018 · 5 comments
Closed

Improvements to the docs #7

yanokwa opened this issue May 7, 2018 · 5 comments

Comments

@yanokwa
Copy link
Member

yanokwa commented May 7, 2018

  • DO now have two types of droplets and it could be confusing.
    We should specify that a Standard droplet, not an Optimized droplet is needed.

screen shot 2018-05-07 at 10 56 14

  • Step 12 requires make to be installed, but make is not installed. We will need to add a apt-get install make.

  • Step 13 makes it sound like if you run systemctl start docker-compose@effective-spork and see that the system is active, things are working. Based on what I can see, it can take a few minutes for the container to boot and run all the things
@yanokwa
Copy link
Member Author

yanokwa commented May 7, 2018

It would be super nice if some of these commands were in a list so I don't have to copy and paste stuff from inside a paragraph.

@issa-tseng
Copy link
Member

wrt commands in a list: can you paste an example of what that might look like? i'm not sure how to integrate the prose and commands in a list. or do you just mean to also provide a separate list?

issa-tseng added a commit that referenced this issue May 8, 2018
@issa-tseng
refactor #7: use an intermediate container vice Make to write version.
4722fcc 
* the digital ocean docker image does not have Make by default.
* so rather than pollute the host image with customization, just use
  docker itself (it seems the answer to all questions in dockerland is
  to force everything to look like a docker-nail).
* this makes the build longer but it's pretty clean.
* and it paves a way to answer #2.
* progress on #7.
* also reorder the lines in nginx.dockerfile to avoid layering.
issa-tseng added a commit that referenced this issue May 8, 2018
@issa-tseng
new #7: add explicit healthcheck to nginx for better status checking.
680e29d 
* progress on #7.
@yanokwa
Copy link
Member Author

yanokwa commented May 9, 2018

Instead of this

Next, you need to bundle everything together into a server. Run docker-compose build to do this. When that finishes, run docker-compose create.

I'd prefer this

Next, you need to bundle everything together into a server. Run the following commands...

docker-compose build;
docker-compose create;

That is, it's easer to copy and paste stuff when it's not inline.

https://www.digitalocean.com/community/tutorials/how-to-install-apache-tomcat-8-on-ubuntu-16-04 does what I've come to expect.

@issa-tseng
Copy link
Member

The only problem with that is that I don't know how to do that and make the numbered list continue in Markdown. Any tips? Or can we save this formatting detail for what we both agree will be some other final destination?

@yanokwa
Copy link
Member Author

yanokwa commented May 9, 2018

Save the formatting detail for a quick contributor win at some point in the future...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yanokwa @issa-tseng