Prep v2023.5.1 #594
Merged
Prep v2023.5.1 #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Jan 29, 2024
lognaturel
force-pushed
the
prep-v2023.5.1
branch
from
278462e
to
1f7dee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a draft forum post ready to go at https://forum.getodk.org/t/odk-central-v2023-5-entity-updates-via-submissions/44311/2
What has been done to verify that this works as intended?
This branch is currently running on https://dev.getodk.cloud I verified converting a form with pyxform and making submissions with Enketo.
Why is this the best possible solution? Were any other approaches considered?
We've now fixed all known issues coming out of the pyxform 2.0.0 changes so it feels like a good time to upgrade pyxform.
Enketo as currently in Central v2023.5.0 changes annotation files any time an edit is made to the corresponding submission, whether or not the edit involved changes to the annotation file. That seems worth fixing asap.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I believe the pyxform change is very low risk. The Enketo change will be somewhat disruptive because it rolls back some improvements but I think it's the right call (see enketo/enketo#1292)
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production) -- Branching off master because this is intended to be released right away.