Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved styling the Form end screen #5571

Merged
merged 2 commits into from
May 10, 2023

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented May 8, 2023

Closes #5570

What has been done to verify that this works as intended?

I've verified implemented changes manually:

Screenshot_1683536452

Why is this the best possible solution? Were any other approaches considered?

This is what we discussed during our Friday call.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I think it doesn't require testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from seadowg May 8, 2023 09:30
@grzesiek2010 grzesiek2010 added the high priority Should be looked at before other PRs/issues label May 8, 2023
@seadowg seadowg requested a review from alyblenkin May 8, 2023 14:03
@seadowg
Copy link
Member

seadowg commented May 8, 2023

@alyblenkin I'll send you a build on Slack

@alyblenkin
Copy link
Collaborator

Hey @grzesiek2010 @seadowg. The last screen is looking good. The only thing is the background of the message is a bit dark. I was hoping we could do an opacity of the primary colour. I mocked it up with 10% opacity; however, that might be a little too light, so we should go with 15% opacity.

@seadowg
Copy link
Member

seadowg commented May 9, 2023

@alyblenkin @grzesiek2010 maybe it makes sense for us to use a low emphasis version of our Primary color as the "Surface Container High" Material 3 color that "Filled" Cards (which this looks most like) use. That seems to fit with the default Material theme - Surface Container High looks like a faded version of their Primary. @grzesiek2010 it looks like that's another unreleased attribute, so we'd need to define it in attrs.xml until they release the new Material Components with the rest of the Material 3 colors.

@grzesiek2010
Copy link
Member Author

@seadowg and then change cardBackgroundColor which defines what color is used as a background?

@seadowg
Copy link
Member

seadowg commented May 9, 2023

@grzesiek2010 Yeah I think that's right

@grzesiek2010
Copy link
Member Author

Ok It's ready. The new color compared to the old one:

Now Before
Screenshot_1683703253 Screenshot_1683667078

@grzesiek2010 grzesiek2010 requested a review from seadowg May 10, 2023 07:22
@grzesiek2010 grzesiek2010 merged commit 0062ac2 into getodk:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling the last screen before you finalize or send the form
3 participants