-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved styling the Form end screen #5571
Conversation
@alyblenkin I'll send you a build on Slack |
Hey @grzesiek2010 @seadowg. The last screen is looking good. The only thing is the background of the message is a bit dark. I was hoping we could do an opacity of the primary colour. I mocked it up with 10% opacity; however, that might be a little too light, so we should go with 15% opacity. |
@alyblenkin @grzesiek2010 maybe it makes sense for us to use a low emphasis version of our Primary color as the "Surface Container High" Material 3 color that "Filled" Cards (which this looks most like) use. That seems to fit with the default Material theme - Surface Container High looks like a faded version of their Primary. @grzesiek2010 it looks like that's another unreleased attribute, so we'd need to define it in |
@seadowg and then change |
@grzesiek2010 Yeah I think that's right |
bae4439
to
523243e
Compare
Closes #5570
What has been done to verify that this works as intended?
I've verified implemented changes manually:
Why is this the best possible solution? Were any other approaches considered?
This is what we discussed during our Friday call.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I think it doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.