Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all foreground services have a type #5586

Merged
merged 1 commit into from
May 16, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented May 15, 2023

This will be required for apps targeting Android 14, and it sounds like it's part of an effort to make foreground services more resilient on Samsung phones.

Fixing this was simpler than writing an issue.

What has been done to verify that this works as intended?

Ran tests.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Checking background audio recording (not part of question) would be worthwhile here. Nothing else has been touched.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg changed the title Make sure all foreground services have type Make sure all foreground services have a type May 15, 2023
@seadowg seadowg marked this pull request as ready for review May 15, 2023 10:44
@grzesiek2010 grzesiek2010 merged commit 609fad6 into getodk:master May 16, 2023
@seadowg seadowg deleted the foreground-service-type branch May 16, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants