Preserve range widget values in field list when minimizing app #5640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
COLLECT-5530
branch
from
e4ab62c
to
bfa109d
Compare
grzesiek2010
force-pushed
the
COLLECT-5530
branch
from
bfa109d
to
33e9790
Compare
seadowg
approved these changes
Jul 6, 2023
|
Merging this now, as it's fairly contained and so makes sense to verify on |
|
Tested with Success! Verified on device with Android 12, 13 Verified Cases:
|
lognaturel
changed the title
lognaturel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5530
What has been done to verify that this works as intended?
I've tested the fix manually and added automated tests.
Why is this the best possible solution? Were any other approaches considered?
Slidersneed to have their own unique ids (just likeEditTextsandCheckboxes) otherwise because of android internal mechanism of restoring their state bugs like this one might occur.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Please just verify that the issue is solved but it's the second issue like that (after #5523) where there are problems when we have two the same widgets on one page so please play with other widgets in the same way more in the future.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.