Protect against onResume running in MainMenuActivity during crash flow
#5679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not happen as far as we understand, but seems to be occuring in the wild on some devices and is also reproducible in Robolectric
seadowg
changed the title
onResume running in MainMenuActivity during crash flow
| CrashHandler.getInstance(application)!!.registerCrash(application, IllegalStateException()) | ||
|
|
||
| val activity = Robolectric.setupActivity(MainMenuActivity::class.java) | ||
| assertThat(shadowOf(activity).nextStartedActivity, notNullValue()) |
There was a problem hiding this comment.
Shouldn't we also check that the new activity is CrashHandlerActivity as the title says? Here you just check if it's not null.
grzesiek2010
approved these changes
Jul 18, 2023
|
@seadowg |
I haven't found an on device way to reproduce, so yeah I'm going to go ahead and merge. |
seadowg
added a commit
to seadowg/collect
that referenced
this pull request
Jul 28, 2023
Protect against `onResume` running in `MainMenuActivity` during crash flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this crash.
The crash is fairly rare, but I ended up fixing it while investigating.
What has been done to verify that this works as intended?
New tests.
Why is this the best possible solution? Were any other approaches considered?
I didn't think we'd need to do this, but it seems like some devices might call
onResumeafter anonCreatethat callsfinishand the fact that this is reproducible in Robolectric definitely backs that up.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The only thing affected is the flow when reopening the app after a crash, so that would be good to play with.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.