Show warning when editing finalized form

[grzesiek2010]

Closes #5680

What has been done to verify that this works as intended?

I've tested the changes manually and updated automated tests.

Why is this the best possible solution? Were any other approaches considered?

Displaying the warning in FormUriActivity ensures that it will be displayed no matter how the form editing is started (from any place in ODK Collect or an external app).

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I think that testing editing forms (drafts too) would be enough and there is not a big risk here. Please keep in mind that the warning should not be displayed after October 1st.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[dbemke]

After changing dark/ light mode to the opposite mode compared to the device's mode there are parts of the wrong mode applied. As far as I remember issues connected with opposite modes won't be fixed but just to let you know that it exists also in the warning. If you decide that it's possible to fix, let me know and I'll figure out some reproducible steps.

[dbemke]

This one is connected with the previous PR introducing the possibility to edit finalized form. I was away when it was introduced and I don't know if this case was discussed but the end page says "You will not be able to make edits once you finalize..." and now it's temporarily possible so it might be a bit confusing.

[grzesiek2010]

This one is connected with the previous PR introducing the possibility to edit finalized form. I was away when it was introduced and I don't know if this case was discussed but the end page says "You will not be able to make edits once you finalize..." and now it's temporary possible so it might be a bit confusing.

It is confusing but we decided that we should not change anything there. Even the snackbar action is View when you finalize but it allows you to edit forms.

[grzesiek2010]

After changing dark/ light mode to the opposite mode compared to the device's mode there are parts of the wrong mode applied. As far as I remember issues connected with opposite modes won't be fixed but just to let you know that it exists also in the warning. If you decide that it's possible to fix, let me know and I'll figure out some reproducible steps.

It should be fixed.

@seadowg was there any reason not to use the LocalizedActivity in FormUriActivity?

[seadowg]

@seadowg was there any reason not to use the LocalizedActivity in FormUriActivity?

I guess it probably didn't have any UI when it was first made? Other than that, I can't think of a reason.

[srujner]

Tested with Success alongside with @dbemke

Verified on device with Android 10,13

Verified cases:

• Sending finalized Forms, Editing saved Forms, Viewing sent Forms, Deleting saved Forms;
• Form version and media updates;
• Viewing Snackbar after sending a form
• Sending forms with big-sized media
• All auto send options
• Forms being sent at the same time