Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep .3 #5695

Merged
merged 6 commits into from
Jul 27, 2023
Merged

Prep .3 #5695

merged 6 commits into from
Jul 27, 2023

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Jul 27, 2023

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

We considered letting the warning be English-only. However, it's important for workflows that involve a review step and we want people to understand that the grace period is temporary. We considered putting the string in Transifex but we decided that using Google Translate strikes a reasonable balance between providing value and not taking too long to do. We will hopefully get user feedback if it's really bad.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

We've had trouble with translation changes breaking tests. I made sure sv-rSE is unchanged. I do think there's some risk that the automatically generated translations will be bad. The hope is that they'll be better than nothing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

getodk/docs#1636

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@lognaturel
Copy link
Member Author

@grzesiek2010 @seadowg can one of you please run connected tests on this? I need a reminder of how to do it these days! Hopefully it can then be merged so I can finally release.

@seadowg
Copy link
Member

seadowg commented Jul 27, 2023

All ✅

@lognaturel lognaturel marked this pull request as ready for review July 27, 2023 14:31
@lognaturel lognaturel merged commit b346829 into getodk:v2023.2.x Jul 27, 2023
@lognaturel lognaturel deleted the prep-.3 branch July 27, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants