Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging when showing crash report screen #5698

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jul 28, 2023

This adds logging when showing the crash reporting screen to verify whether it's the culprit for this crash or not.

@seadowg seadowg changed the base branch from master to v2023.2.x July 28, 2023 15:53
@seadowg seadowg marked this pull request as ready for review July 28, 2023 15:54
@seadowg seadowg added this to the v2023.2.x milestone Jul 28, 2023
@seadowg
Copy link
Member Author

seadowg commented Jul 28, 2023

@lognaturel I think we should merge and release this ASAP to get a sense of what's going on with the crash. My current theory is that it's possible to get into a nasty place where onResume runs after onCreate AND before the Activity state is moved so that isFinishing is true. Before writing code to work around that impossible (according to docs) situation, I'd like to get more proof.

And just to clarify why I feel this is important, if I am right that it's a problem with showing crashes then the user will be stuck in that scenario until they uninstall/reinstall or clear storage.

@seadowg seadowg requested a review from lognaturel July 28, 2023 15:58
@grzesiek2010 grzesiek2010 merged commit 422b7ed into getodk:v2023.2.x Aug 3, 2023
@seadowg seadowg deleted the crash-report-logging branch August 3, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

2 participants