Fixed missing „form resume” in audit log events when moving backward in not allowed in Collect settings #5708
Conversation
| CollectHelpers.killAndReopenApp() | ||
| } | ||
|
|
||
| MainMenuPage().startBlankForm("One Question Audit") |
There was a problem hiding this comment.
I think it'd make sense for the test to save and exit the form as well to check the audit log is in the state we think it should be after the session has ended (as that's what would get uploaded).
| val device = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation()) | ||
|
|
||
| // kill | ||
| device.pressRecentApps() |
There was a problem hiding this comment.
Wow I'd not realised you could do this! I think I tried something similar, but kept ending up with the test exiting as soon the app was killed.
A couple of things here:
- I think that
killAndReopenAppcould just be a method onPage. To be really purist about it, it could take both a package name to restart and a destination page to assert on (here you'd pass"org.odk.collect.android"and aMainMenuPageinstance). - It looks like this doesn't actual restart the process (
Application#onCreateis not called again). We do already have a helper for simulating that (CollectHelpers.simulateProcessRestartcould be called after theswipeUpthough.
There was a problem hiding this comment.
I think that killAndReopenApp could just be a method on Page. To be really purist about it, it could take both a package name to restart and a destination page to assert on (here you'd pass "org.odk.collect.android" and a MainMenuPage instance).
Done but do the package name I used BuildConfig.APPLICATION_ID so that we don't have to hardcode it.
It looks like this doesn't actual restart the process (Application#onCreate is not called again). We do already have a helper for simulating that (CollectHelpers.simulateProcessRestart could be called after the swipeUp though.
Maybe the process is not restarted to keep the test running... never mind I've added CollectHelpers.simulateProcessRestart().
grzesiek2010
force-pushed
the
COLLECT-5253
branch
from
67aa129
to
b484904
Compare
|
The "form resume" event is present but the last question before killing the app is missing. On the master version the last question (before killing) also appears only once but there isn't the form resume question so then seems ok. Should there be two events for the last question- event before killing the app and event after going back to the app? So I'm not really sure if it's a separate issue or the PR. Steps to reproduce:
Text 3 question is missing before the "form resume" event. It appears after the event (going back to the app). |
|
It works fine to me if on master that question is also logged only once. I think this will be fixed in #5721 |
|
Tested with Success! Verified on the device with Android 10 Verified cases:
The mentioned issue will be tested again along with #5721 |
|
Tested with Success! Verified on the device with Android 13 |
Closes #5253
What has been done to verify that this works as intended?
I've added automated tests and verified the fix manually.
Why is this the best possible solution? Were any other approaches considered?
There is nothing to discuss here.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should just fix the issue. I don't think it can affect anything else.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.