Do not allow to attach gifs in AnnotateWidget #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
COLLECT-5485
branch
from
b236bc4
to
9b6ac10
Compare
grzesiek2010
force-pushed
the
COLLECT-5485
branch
from
9b6ac10
to
a6e1713
Compare
seadowg
approved these changes
Sep 12, 2023
|
Tested with Success! Verified on Androids: 10 Verified cases:
A separate issue was filed for a crash after uploading a broken file to Annotate widget (present on the mastger version). |
|
Tested with Success! Verified on Androids: 13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5485
What has been done to verify that this works as intended?
I've tested the fix manually and added automated tests.
Why is this the best possible solution? Were any other approaches considered?
In the issue, I said that a good solution would be to just update the intent that opens the file picker and filter available files excluding gifs so that only other types of images are visible to select. This would be a nice solution but error-prone because when we build such an intent it's not possible to exclude gifs, instead we would have to pass a list of supported mime types and easily miss something. A better solution in this case would be to still allow selecting gifs in the file picker but blocking attaching them in the widget.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I think focusing on the fix should be enough. It shouldn't affect any other functionalities.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.