Refresh the list adapter to solve the problem with selecting items

[grzesiek2010]

Closes #5552

What has been done to verify that this works as intended?

I've tested the fix manually.

Why is this the best possible solution? Were any other approaches considered?

We have two lists there represented by two tabs (ViewPager2):

• saved forms - the list is built with the old SimpleCursorAdapter
• blank forms - the list is built with RecyclerView

it looks like there is something wrong when we combine ViewPager2 with SimpleCursorAdapter. I was thinking about refactoring that list what we will need to do at some point either way but I was able to come up with a smaller fix for now which is refreshing the adapter when it became visible.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The change is small so we can focus only on that view with two tabs (for blank and saved forms). Please make sure there is no regression there and that should be enough.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[srujner]

Tested with Success!

Verified on device with Android 13

Verified cases:

• Issue Unable to select a form in Saved Forms after going back from Blank Forms #5552 is no longer reproducing;
• Regression check on Saved Forms and Blank Forms tabs;
• Deleting Saved/Blank Forms;
• Minimize the app, rotate the screen;
• Light and Dark mode;
• Don't keep activities enabled/disabled;

[dbemke]

Tested with Success!