Fixed: Doubled event in the audit log after saving a draft in Audit Test Location Background Audio form #5742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5659
Closes #5752
What has been done to verify that this works as intended?
I've tested the fix manually and added automated tests.
Why is this the best possible solution? Were any other approaches considered?
The problem was that when background recording was being finished then audit logs were flushed but after that, we called
onScreenRefresh
which caused logging events from the current screen again. I could write a method that would compare those already logged events with new ones (maybe this is something we will need at some point either way but hopefully not because this would be cumbersome) but in this case, avoiding thatonScreenRefresh
is a better solution.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Apart from the issue itself please test Background audio recording and the Audio widget to make sure there is no regression.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.