Fixed the order of events when location tracking is enabled

[grzesiek2010]

Closes #5262

What has been done to verify that this works as intended?

I've tested the fix manually and added automated tests.

Why is this the best possible solution? Were any other approaches considered?

Enabling background recording takes place when we call activityDisplayed() when we navigate back from the hierarchy view we need to do that earlier than in onResume() because it's after refreshing the screen and logging the question event.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Apart from verifying that the issue has been fixed, it would be good to play a little bit with background location recording to make sure there is no regression.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[dbemke]

We're testing the PR with the CircleCI apk and there is only OSM available. Do you think there might be any differences for other sources of maps in background location? Or testing OSM is enough?

[grzesiek2010]

We're testing the PR with the CircleCI apk and there is only OSM available. Do you think there might be any differences for other sources of maps in background location? Or testing OSM is enough?

testing one provider will be enough.

[dbemke]

When "don't keep activities" setting is enabled after following the steps from the issue tracking location event appears after the first opened question after form resume.
If the user fills the form and at some point goes to the hierarchy view, taps "Go to end" tracking location events appears after end screen event - it occurs also on the master version but I'm not sure if it's ok for tracking location events to appear in that situation?

[grzesiek2010]

This should be fixed now.

[dbemke]

With don't keep activities on and the steps from the issue it works as expected.
Going to the hierarchy view (+don't keep activities) still adds location events - should I file this one separately?

[grzesiek2010]

should I file this one separately?

yes.

[srujner]

Tested with Success!

Verified on device with Android 12,13

Verified cases:

• Issue The order of question and location tracking enabled events in audit log after form resume #5262 is no longer reproducing;
• OSM;
• don't keep activities enabled/disabled;
• Regression check on background location recording;
• Screen rotation, minimize app, using backward button,

[dbemke]

Tested with Success!

Verified on device with Android 10