Fixed importing QR codes #5747
Merged
Fixed importing QR codes #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
qrerror
branch
from
348c914
to
8c98b0b
Compare
seadowg
approved these changes
Oct 3, 2023
|
Tested with Success! Verified on device with Android 8.1, 10 Verified cases:
|
|
Tested with Success! Verified on device with Android 5.1, 12,13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5748
What has been done to verify that this works as intended?
I've tested the changes manually and also added automated tests.
Why is this the best possible solution? Were any other approaches considered?
I don't know how zxing works under the hood but obviously using
DecodeHintType.PURE_BARCODE to FALSEcaused problems with scanning some QR codes. That parameter seems to be redundant so I juts got rid of it.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I think we can focus on testing importing QR codes. I was able to reproduce the issue with the one attached on the forum https://forum.getodk.org/t/importing-a-qr-with-odk-collect-does-the-size-of-the-image-matter/43071/1 and with the one I used in tests: https://github.com/getodk/collect/pull/5747/files#diff-08ee19f4a8d2e6438261e7192493809104b12fe010229802bf088ee63723fc09
Please play with settings/generating qr codes and see if you can do the same on your own. Generally, if a QR code is shared by ODK Collect via email for example it works well but if you take a screenshot it's not always the case.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.