Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handing fast clicking on different elements in the main menu #5759

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Oct 3, 2023

Closes #5307

What has been done to verify that this works as intended?

I've tested the changes manually.

Why is this the best possible solution? Were any other approaches considered?

As I said in the comment:

   /*
    Utilizing screen names instead of class names offers a more robust approach, as elements placed
    on the same user interface screen may potentially belong to distinct classes (such as fragments or custom views).
    Consequently, employing screen names for identification ensures that these elements are recognized
    as components of the same screen, disabling rapid clicking.
     */

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Please test fast clicking on main menu elements (buttons and the project icon). It's an isolated change so we can focus on the main menu only.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 changed the title Collect 5307 Improved handing fast clicking on different elements in the main menu Oct 3, 2023
@srujner
Copy link

srujner commented Oct 9, 2023

Tested with success!!

Verified on device with Android: 12, 13

Verified cases:

@dbemke
Copy link

dbemke commented Oct 9, 2023

Tested with success!!

Verified on device with Android: 8.1, 10

@grzesiek2010 grzesiek2010 merged commit b5558c6 into getodk:master Oct 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to tap project icon and a button from the main menu at the same time
4 participants