Add checks for tests and string comments to PR template #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
commented
Oct 4, 2023
| @@ -4,11 +4,9 @@ Closes # | |||
| Thank you for contributing to ODK Collect! | |||
|
|
|||
| Before sending this PR, please read | |||
| https://github.com/getodk/collect/blob/master/CONTRIBUTING.md | |||
| https://github.com/getodk/collect/blob/master/docs/CONTRIBUTING.md | |||
There was a problem hiding this comment.
This had moved which definitely wouldn't help!
seadowg
commented
Oct 4, 2023
| --> | ||
|
|
||
| #### What has been done to verify that this works as intended? |
There was a problem hiding this comment.
I've switched this for a checklist item so that it's clear that tests are the default and that manual checking would be an exception that would need to be justified.
seadowg
changed the title
grzesiek2010
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think being more explicit about these will be useful for external contributors.