Specify when formIndex should be updated when there are errors during validating answers

[grzesiek2010]

Closes #5847

Why is this the best possible solution? Were any other approaches considered?

The problem was that every time we validated a form if there were errors the form index was changed. This should not happen if we just save the form using the save icon from the toolbar (we still need to validate answers to know if there are errors in this case). Updating the index is needed when we Check for errors or try to finalize a form to move a user to the invalid question. So the solution was to introduce a new parameter to explicitly tell the method that validates answers if the index should be updated.

Another option would be to move updating index out of the validateAnswers method but then we would need to add this to more than one method and those methods are not better places for such an operation.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

We need to test validating answers carefully:

• finalizing forms with errors
• using the Check for errors option from the toolbar (with errors)
• saving forms using the save icon from the toolbar

Do we need any specific form for testing your changes? If so, please attach one.

Any form with required questions that could be invalid so required questions without answers or questions with constraints.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• added a comment above any new strings describing it for translators
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[seadowg]

Another option would be to move updating index out of the validateAnswers method but then we would need to add this to more than one method and those methods are not better places for such an operation.

I do think this is the better long term move, but I agree that it would require a little more of a rethink around the interface than we'll want to do for this bug fix.

[dbemke]

Can you check the form mentioned in the issue (two-question-required.xml.txt))? Central can't upload the form because there isn't meta group in the form.

[grzesiek2010]

Can you check the form mentioned in the issue (two-question-required.xml.txt))? Central can't upload the form because there isn't meta group in the form.

I took it from our tests but it could be any form with two questions (the second one should be required). This one should work:
req.xlsx

[srujner]

Tested with Success!

Verified on device with Android 13

Verified cases:

• Issue A user is moved to the question that comes after/before the first invalid question when they click the save icon and try to navigate forward/backward #5847 is no longer reproducing;
• Regression check on Forms with Required question;
• Finalizing forms with errors;
• Bulk Finalize forms with/without errors;
• Editing Draft with/without errors;
• Using the Check for errors option from the toolbar (with errors);
• Saving forms using the save icon from the toolbar;
• Discarding changes in required fields;
• Discarding changes in required fields after using Save icon;
• Rotate the screen, minimize the app;
• Don't keep activities enabled/disabled;
• Light and Dark mode.

[dbemke]

Tested with Success!

Verified on device with Android 10