Finish activity when the dialog is canceled

[grzesiek2010]

Closes #5872

Why is this the best possible solution? Were any other approaches considered?

When the dialog is closed the activity should be finished too. No matter if we close the dialog by clicking the cancel button or press the device back button.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I've just fixed the issue making sure the activity is always finished when we close the error dialog. It's a safe change so we can focus on testing the scenario described in the issue.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
• added a comment above any new strings describing it for translators
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[seadowg]

Why do we need this test when all the other tests now assert on the cancellation behaviour?

[grzesiek2010]

Why do we need this test when all the other tests now assert on the cancellation behaviour?

All the existing tests verified clicking the cancel button but the new one pressing the back button.

[srujner]

Tested with Success!

Verified on device with Android 10,12,13

• Issue Clicking back button or outside the error dialog area in FormUriActivity does not closes the activity #5872 is no longer reproducing;