Fixed marking converted projects as old GD projects

[grzesiek2010]

Closes #5903

Why is this the best possible solution? Were any other approaches considered?

The problem was the way we implemented marking projects as old GD projects see: https://github.com/getodk/collect/pull/5909/files#diff-a091971b93c91fe4e50308d51b4b3abebac66e51711552f955e75feb504ea928L30
it worked well with existing tests because they used test implementation of ProjectsRepository and simply updating the objects stored on a list (not in shared prefs) worked well.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This is a small fix so we can focus on testing the scenario described in the issue. I don't think there is any bigger risk here.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
• added a comment above any new strings describing it for translators
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[seadowg]

An alternative solution I think would be worth considering is to add a test in ProjectsRepositoryTest (the "contract" test) to cover the difference in behaviour between the two implementations and then get that passing. Then you can continue to use the fake rather than the real implementation in tests.

What do you think?

[grzesiek2010]

An alternative solution I think would be worth considering is to add a test in ProjectsRepositoryTest (the "contract" test) to cover the difference in behaviour between the two implementations and then get that passing. Then you can continue to use the fake rather than the real implementation in tests.
What do you think?

I don't think the bug we had was something I could test using ProjectsRepositoryTest. The problem was that isOldGoogleDriveProject was a variable that we were able to change and assume it updates the saved project no matter if it's stored using shared prefs or a list in memory (InMemProjectsRepository), of course it didn't work with shared prefs. I've updated isOldGoogleDriveProject so that now it's val and I think we can revert the changes in tests.

[dbemke]

Tested with Success!

Verified on a device with Android 10

Verified cases:

• the banner is displayed correctly
• upgrading with a GD project with and without drafts and finalized forms
• resetting the project after upgrading
• trying to reconfigure an upgraded GD project with a QR code with an old GD project

[srujner]

Tested with Success!

Verified on a device with Android 13