Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed applying proper theme in FormUriActivity #6050

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Mar 27, 2024

Closes #6043

Why is this the best possible solution? Were any other approaches considered?

The whole activity (FormUriActivity) didn't work well with different themes (the problem was not only with that particular dialog described in the issue). I've fixed the issue by applying the same approach (our LocalizedActivity) as we do in other places of the app.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It's a safe fix so you can focus on the scenario that is described in the issue. I can't see any risk that you would need to be aware of.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review March 28, 2024 10:16
@seadowg seadowg merged commit 71a4b73 into getodk:master Mar 29, 2024
6 checks passed
@srujner
Copy link

srujner commented Mar 29, 2024

Tested with Success!

Verified on device with Android 12, 13

Verified cases:

@dbemke
Copy link

dbemke commented Mar 29, 2024

Tested with Success!

Verified on device with Android 10, 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong theme applied in the recovery dialog when there are opposite themes
4 participants