Fixed resetting layers to none in preferences #6193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
COLLECT-6192
branch
from
1f58454
to
4f07033
Compare
seadowg
approved these changes
Jun 17, 2024
|
Tested with success Verified on device with android 14 Verified cases:
|
|
Tested with success Verified on device with android 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6192
Why is this the best possible solution? Were any other approaches considered?
It was a stupid mistake with an extra line left in https://github.com/getodk/collect/pull/6184/files#diff-36f54d94492ef437156984d26797b377ab56d837b458397629723df876d81e1dR159
I've added more tests to cover this case.
The only additional change worth discussing is that I've reworked the
getmethod from DirectoryReferenceLayerRepository.kt so that now it doesn't return a layer if it's an unsupported one. Thanks to that I don't have to check if a layer is supported in preferences. This might look weird at first glance but it matches whatgetAlldoes so now it's consistent.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Everything that is related to displaying proper layers/layer names is at risk.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest