Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ExternalAppIntentProvider #6247

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jul 3, 2024

Closes #6246

Why is this the best possible solution? Were any other approaches considered?

There is nothing to discuss here as it just fixes a small bug.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Please test starting external apps ideally with parameters like the counter app with increment/autoincrement. Nothing else than that (reading package names and parameters) can be affected by this change.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg merged commit 695e32f into getodk:master Jul 3, 2024
6 checks passed
@grzesiek2010 grzesiek2010 added the high priority Should be looked at before other PRs/issues label Jul 4, 2024
@srujner
Copy link

srujner commented Jul 5, 2024

Tested with Success!
Verified on device with Android 13
Verified cases:

@WKobus
Copy link

WKobus commented Jul 5, 2024

Tested with Success!
Verified on device with Android 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counter app - question increment set to true doesn't open the app
4 participants