Fix tests #6263
Merged
Fix tests #6263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Jul 16, 2024
|
|
||
| private fun toggleLayer(position: Int) { | ||
| onView(withRecyclerView(R.id.layers).atPositionOnView(position, R.id.arrow)).perform(click()) | ||
| WaitFor.wait250ms() |
There was a problem hiding this comment.
Could we not wait for something here (WaitFor.waitFor for example) instead of just waiting a fixed amount of time? That doesn't give us any guarantee that we've waited enough.
Also, did you try things like using the InstantTaskExecutor or maybe even checking if animations are somehow still enabled?
There was a problem hiding this comment.
Could we not wait for something here (WaitFor.waitFor for example) instead of just waiting a fixed amount of time? That doesn't give us any guarantee that we've waited enough.
Yeah, we can use it.
Also, did you try things like using the InstantTaskExecutor or maybe even checking if animations are somehow still enabled?
I did, but nothing worked.
seadowg
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this the best possible solution? Were any other approaches considered?
I've run the tests ~5 times on CIrcleCI and everything seems to work well. The solution with waiting 250ms https://github.com/getodk/collect/pull/6263/files#diff-d01d0d1c510ce76157b059be58bc430ae9005f767acf8a6e7aadbc124a5ca0f3R827 is not what we like but nothing else worked. It looks like espresso needs some time to finish expanding layers. The same is true with changing selection. Those tests failed locally like twice for 100 runs so very rarely. I'm not sure if it was caused by non-responsive UI or maybe it also needs some time between changing selection and checking the state but
tryAgainOnFailefixed the problem,How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest