Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show entity id and version on list #6313

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Aug 7, 2024

As discussed at #6307. This adds entity ID and version to the entity browser to make it easier to diagnose problems.

Why is this the best possible solution? Were any other approaches considered?

Not a lot to discuss here. I just added a new view to show the info.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This only affects the entity browser which is not available in general releases so there's very little risk.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review August 7, 2024 11:27
@grzesiek2010 grzesiek2010 merged commit 8f3ffc1 into getodk:master Aug 13, 2024
6 checks passed
@seadowg seadowg deleted the view-entity-id branch August 13, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants