Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JavaRosa to 4.4.1 for CSV parse improvements #6342

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Aug 13, 2024

This should reduce memory usage when parsing CSV secondary instances

Why is this the best possible solution? Were any other approaches considered?

See getodk/javarosa#787

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Risk is isolated to CSV secondary instances. It should be low.

Do we need any specific form for testing your changes? If so, please attach one.

Any form with attached CSV, especially a large one.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg self-requested a review August 14, 2024 10:11
@seadowg seadowg added the high priority Should be looked at before other PRs/issues label Aug 14, 2024
@seadowg
Copy link
Member

seadowg commented Aug 14, 2024

@lognaturel tests look green!

@seadowg seadowg merged commit a59d338 into getodk:v2024.2.x Aug 14, 2024
6 checks passed
@lognaturel lognaturel deleted the jr-csv-parse branch August 14, 2024 18:04
@WKobus
Copy link

WKobus commented Aug 16, 2024

Tested with Success:

Verified on device with Android 14, 10

Verified cases:

  • Big select forms with CSV
  • Regression check on audit forms
  • Regression check on entity forms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants