Log error instead of throwing security exception #6363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
commented
Aug 21, 2024
| object PathUtils { | ||
|
|
||
| @JvmStatic | ||
| fun getRelativeFilePath(dirPath: String, filePath: String): String { | ||
| return if (filePath.startsWith(dirPath)) filePath.substring(dirPath.length + 1) else filePath | ||
| } | ||
|
|
||
| @JvmStatic | ||
| fun getAbsoluteFilePath(dirPath: String, filePath: String): String { |
There was a problem hiding this comment.
I had to move this whole method to the androidshared module because the shared one is a pure java/kotlin module and I can't use Timber or Analytics there. I've tried SLF4J to no avail. I think we should file an issue to figure out how to log things in such modules.
seadowg
requested changes
Aug 21, 2024
| assertThat(path, equalTo(nonCanonicalPath + File.separator + "file")) | ||
| } | ||
| // @Test | ||
| // fun `getAbsoluteFilePath() returns filePath prepended with dirPath`() { |
There was a problem hiding this comment.
Can we move this as well and just ignore the tests for the SecurityException?
grzesiek2010
force-pushed
the
disable_security_exception
branch
from
a091036
to
e3f3d60
Compare
seadowg
approved these changes
Aug 21, 2024
seadowg
added a commit
to seadowg/collect
that referenced
this pull request
Aug 22, 2024
…eption Log error instead of throwing security exception
seadowg
added a commit
to seadowg/collect
that referenced
this pull request
Aug 23, 2024
…eption Log error instead of throwing security exception
grzesiek2010
pushed a commit
to grzesiek2010/collect
that referenced
this pull request
Oct 29, 2024
…eption Log error instead of throwing security exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this the best possible solution? Were any other approaches considered?
As we discussed on slack with @seadowg there is something wrong with the way analyze paths and throw the
SeciurityExceptionso we should stop doing that (throwing the exception) until we know what is going on there and can properly fix the code.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest