Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the counter widget in rtl languages #6370

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Aug 22, 2024

Closes #6365

Why is this the best possible solution? Were any other approaches considered?

I attempted to use android:autoMirrored="true", which works with vector drawables, but it doesn't seem to have any effect in this case. Therefore, providing separate versions of the files for RTL languages appears to be the only solution.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It just requires testing how the counter widget looks in both LTR and RTL languages. That's the only thing I changed.

Do we need any specific form for testing your changes? If so, please attach one.

The one from #6306.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as draft August 22, 2024 15:40
@grzesiek2010 grzesiek2010 marked this pull request as ready for review August 23, 2024 08:32
@dbemke
Copy link

dbemke commented Aug 27, 2024

Tested with Success!

Verified on a device with Android 10, 14

Verified Cases:

@seadowg seadowg merged commit 89cb419 into getodk:master Aug 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counter "+/-" buttons in RTL
3 participants