Add support for range control #39 #44
Conversation
…th because it’s a bad practice and because Arrays.asList, which is a handy way to create the argument for this parameter, creates a fixed-size List.
…quired to properly collect the attributes.) Add a test.
Conflicts: test/org/javarosa/xform/parse/XFormParserTest.java
…s start, end and step values in it. Add a new test for a form with a bad data value in a range attribute.
|
@lognaturel, @mitchellsundt and @ctsims, perhaps you’ll have a moment to look over this change. 3911f90 |
|
@dcbriccetti It would be super helpful to know the kind of feedback you're looking for. Do you think it's ready to go and want final review? Is there a particular aspect that you're unsure about? This is a pretty different approach from the way attributes in other contexts are handled but it's clean. |
|
Hi @lognaturel. I was hoping for some reassurance from @mitchellsundt and/or @ctsims, but if you like the tests and the implementation, I say this is ready to go. |
|
This implementation makes sense to me and seems quite clean. I appreciate the lack of appearance attributes full of magic strings :p. |
|
@ctsims, thanks for having a look! |
|
@ctsims Thanks so much for the reassurance as we get our JavaRosa sea legs!! And @dcbriccetti thanks for the clean implementation. Yay for |
Work in progress. Built on the 25-modernize-xformparser branch. The key change is this commit: https://github.com/dcbriccetti/javarosa/commit/a099ca7a927b9051c39b38a97ad40e3c4a1d6a26. There is some prep work earlier in the day, Apr 26.