Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kubernetes as a resource manager #889

Merged
merged 54 commits into from
Aug 22, 2020
Merged

add kubernetes as a resource manager #889

merged 54 commits into from
Aug 22, 2020

Conversation

JayjeetAtGithub
Copy link
Collaborator

@JayjeetAtGithub JayjeetAtGithub commented Jul 21, 2020 •
edited
Loading

TODO:

  1. Unit tests (Need to write tests for more edge cases)
  2. Documentation

Corner Cases

Volume and Node both not given : ✅
Volume given only: If some shared volume then it is ok, otherwise might fail. ✅
Node given only: ✅
Volume and Node both given: ✅

@JayjeetAtGithub JayjeetAtGithub changed the title Kubernetes Add kubernetes as a resource manager Jul 21, 2020
@JayjeetAtGithub JayjeetAtGithub changed the title Add kubernetes as a resource manager WIP: Add kubernetes as a resource manager Jul 21, 2020
@JayjeetAtGithub JayjeetAtGithub force-pushed the kubernetes branch 4 times, most recently from 285195c to 588c6d8 Compare July 30, 2020 16:23
@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review July 31, 2020 12:38
@JayjeetAtGithub
Copy link
Collaborator Author

@ivotron You can follow these instructions to test out the runner.

ivotron
ivotron reviewed Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than a review, I left a couple of questions that would allow to direct better a followup review

src/scripts/install_k8s.sh Show resolved Hide resolved
docs/sections/cn_workflows.md Show resolved Hide resolved
@JayjeetAtGithub
Copy link
Collaborator Author

JayjeetAtGithub commented Aug 14, 2020 •
edited
Loading

@ivotron I have made the changes. Now if you have a workflow that doesn't build an image , you can simply do

popper run -f wf.yml -r kubernetes

Otherwise, you will need to provide the registry_user through the config until #907 is implemented.

@JayjeetAtGithub JayjeetAtGithub changed the title WIP: Add kubernetes as a resource manager add kubernetes as a resource manager Aug 14, 2020
@JayjeetAtGithub
add kubectl
9e729dc
@JayjeetAtGithub
fix linting issues
9cd5b77
@JayjeetAtGithub
add initial version of k8s runner unit test
e6a9d72
@JayjeetAtGithub
skip k8s tests when not needed
c761d14
@JayjeetAtGithub
rebased and black error fixes
e07eaa6
@JayjeetAtGithub
fix skipIf
0aede55
@JayjeetAtGithub
add unit tests
58be3cb
@JayjeetAtGithub
fix black issues
a198780
@JayjeetAtGithub
update tests
f8b723e
@JayjeetAtGithub
remove unwanted dependencies
e93f535
@JayjeetAtGithub
delete pods but not volumes
1374da4
@JayjeetAtGithub
add runner kubernetes tests
64cb15f
@JayjeetAtGithub
black errors fixed
37a5317
@JayjeetAtGithub
add support for setting env in pod
6e2588f
@JayjeetAtGithub
black errors fixed
330b9a3
@JayjeetAtGithub
check for existing volume claim
4a5e6c0
@JayjeetAtGithub
skip k8s test for non k8s runtimes
b674686
@JayjeetAtGithub
update docs
54223e6
@JayjeetAtGithub
fix docs
55c0d2f
@JayjeetAtGithub
add more desc of kubernetes runner in docs
b941f40
@JayjeetAtGithub
make hostpath pv if not provided through config
c927f3b
@JayjeetAtGithub
automatically select node to schedule pod
ead2de3
@JayjeetAtGithub
black errors fixed
d6c6fb5
@JayjeetAtGithub
fix bug in _vol_exists function
58df1bd
@JayjeetAtGithub
add more info statements
1aec1fe
@JayjeetAtGithub
stop deleteing .git dirs
52fdee2
ivotron
ivotron approved these changes Aug 22, 2020
View reviewed changes
Copy link
Collaborator

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ivotron ivotron merged commit 55c3a77 into master Aug 22, 2020
@ivotron ivotron deleted the kubernetes branch August 22, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivotron ivotron ivotron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayjeetAtGithub @ivotron