fix elasticsearch get_schema error when mapping contains no 'properties' key

[truebit]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• New Query Runner (Data Source)
• New Alert Destination
• Other

Description

fix elasticsearch get_schema error when index has no 'properties' key.
This bug could be reproduced by trying to use a elasticsearch instance with .kibana index in it.

The version of Elasticsearch and Kibana I use is 5.6.3. Sample .kibana mappings or any other index which contains _default_ in mappings.

kibana_mappings.txt

I also added exception traceback print for future debugging purposes.

Related Tickets & Documents

#3570

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

no changes

[truebit]

This fix just fixes _default_ mappings in elasticsearch. for dynamic_templates, I cannot find a good way to achieve that.

[lomkju]

Thanks this helped us.

[sunui]

Good job～

[axelsean]

I couldn't get the elastic search.py to run on the docker image, the code below did work for me there

        if not 'properties' in doc:
            return result

[truebit]

@axelsean That's odd. Was that because doc variable is not a dict but a list in your scenario?

[axelsean]

I *think* so, but I'm a real Python novice (written 3 lines in my life !) Dave

…

On Wed, May 8, 2019 at 3:18 AM Xiao Wang ***@***.***> wrote: @axelsean <https://github.com/axelsean> That's odd. Was that because doc variable is not a dict but a list in your scenario? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3692 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEO2TPH6F5PK3AXWKSSEHS3PUKEHDANCNFSM4HEYHE5A> .

[truebit]

Could you debug it by printingdoc content to see what it is?

[aidarbek]

Hi! What about making it a bit shorter and just writing this?

for field, description in doc.get('properties', {}).items():

Thus, there will be no need for previous new lines

[truebit]

Making python code short is a style thing, I am OK with that.
Besides, as latter comments pointed out, the doc may not be a dict. So maybe we still need code below to avoid the "not dict" issue.

if not isinstance(doc, dict):
    return result

[truebit]

Or

if not isinstance(doc, dict) or 'properties' not in doc:
    return result

and keep original code intact.

[arikfr]

Thank you for your effort on this and apologies that it wasn't merged eventually. Due to the state of the current implementation and the inability to properly test new changes, we decided to commit to making a new Elasticsearch query runner (#4293) and will address this and the other issues there.