Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed visual-card alignment #3795

Merged
merged 2 commits into from
May 14, 2019
Merged

Fixed visual-card alignment #3795

merged 2 commits into from
May 14, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented May 13, 2019

  • Bug Fix

Description

Fixes first issue in #3677.

Before After
Screen Shot 2019-05-13 at 15 45 42 Screen Shot 2019-05-13 at 15 45 34

gabrieldutra
gabrieldutra reviewed May 13, 2019
View reviewed changes
Copy link
Member

@gabrieldutra gabrieldutra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍 (negative values are cheats)

One note:
The margin for the items is applied for width > 408 px, we can either change this fix to be applied with @media or just remove the existent margin: 5px 0 (will try to attach the line here).

Line:

redash/client/app/assets/less/redash/redash-newstyle.less

Line 306 in e3d0b17

margin: 5px 0;

data-sources-alignment

@ranbena
Copy link
Contributor Author

ranbena commented May 13, 2019

Cool 👍 (negative values are cheats)

This is my go-to for flexbox best practices and that's what they do 💁‍♂️
https://philipwalton.github.io/solved-by-flexbox/demos/grids/

The margin for the items is applied for width > 408 px, we can either change this fix to be applied with @media or just remove the existent margin: 5px 0 (will try to attach the line here).

10x! Fixed.

@ranbena ranbena merged commit 733b601 into master May 14, 2019
@ranbena ranbena deleted the cards-align branch May 14, 2019 20:10
@weekly-digest weekly-digest bot mentioned this pull request May 20, 2019
Closed
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@ranbena @harveyrendell
Fixed visual-card alignment (getredash#3795)
f93d02b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldutra gabrieldutra gabrieldutra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranbena @gabrieldutra