Support for dropdown of predefined options in data sources setup

[gabrieldutra]

What type of PR is this? (check all applicable)

• Feature

Description

This adds support to use Select in Data sources/Destinations setup.

• Rendering in frontend
• Check if ath is missing backend-wise

Related Tickets & Documents

--

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

[arikfr]

See comment about the schema.

Will it pick some value by default? I think think it should pick either the default value as default and if no default is specified, then it should pick the first value.

[arikfr]

This won't pass schema validation. A valid enum is:

{
    "protocol": {
        "type": "string",
        "enum": ["beeswax", "hiveserver2"]
    }
}

We might want to add our own extension to provide friendly names for options:

{
    "protocol": {
        "type": "string",
        "extendedEnum": [{"value", "beeswax", "name": "Beeswax"}, {"value": "hiveserver2", "name": "Hive Server 2"}]
    }
}

And we will transform extendedEnum into enum before passing it into jsonschema.validate call.

[gabrieldutra]

We might want to add our own extension to provide friendly names for options

That's exactly why I went with the list of objects on that, but yeah, it does make sense to permit a simplified version.

And we will transform extendedEnum into enum before passing it into jsonschema.validate call.

That's the only thing missing in terms of backend code?

[arikfr]

That's the only thing missing in terms of backend code?

I think so.

[gabrieldutra]

Will it pick some value by default? I think think it should pick either the default value as default and if no default is specified, then it should pick the first value.

For now only if you specify a default value, for other cases I went with the placeholder. First value is an option too, I'll update that.

[arikfr]

For now only if you specify a default value, for other cases I went with the placeholder. First value is an option too, I'll update that.

Because it will fail validation if you don't specify a value from the list it's best if we just pick one for you.

[arikfr]

This is not needed: schema is always a dict.

[gabrieldutra]

I was getting a "NoneType has no attribute..." And that's why I put it 😬

[arikfr]

👍