feature: add ability to make the restriction of api calls to private addresses optional #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
approved these changes
Apr 10, 2020
|
Looks like the https://github.com/getredash/redash/blob/master/redash/query_runner/__init__.py#L260-L262 When using the setting: Redash continue to say "Error running query: Can't query private addresses." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add configuration item to make the restriction on private address optional
Related Tickets & Documents
#4193
https://discuss.redash.io/t/error-running-query-cant-query-private-addresses/4568
Mobile & Desktop Screenshots/Recordings (if there are UI changes)