Fix: pagination is broken on the dashboard list page #5516
Merged
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2021
susodapop
pushed a commit
that referenced
this pull request
Jun 17, 2021
6 tasks
guerrerocarlos
pushed a commit
to MasterworksIO/redash
that referenced
this pull request
Jun 30, 2021
* Add test that reproduces issue getredash#5466 * Fix: Duplicate dashboard rows were returned by Dashboard.all() (getredash#5466)
susodapop
pushed a commit
that referenced
this pull request
Oct 2, 2021
susodapop
added a commit
that referenced
this pull request
Oct 2, 2021
susodapop
added a commit
that referenced
this pull request
Oct 2, 2021
denisov-vlad
pushed a commit
to denisov-vlad/redash
that referenced
this pull request
Oct 19, 2021
commit 9c928bd Author: Jesse Whitehouse <jesse@whitehouse.dev> Date: Fri Oct 1 21:13:13 2021 -0500 Bump version to 10.0.0 commit f312adf Author: Jesse <jesse.whitehouse@databricks.com> Date: Fri Oct 1 18:02:27 2021 -0500 Apply V10 beta period feedback / fixes (getredash#5611) The following PR's were cherry-picked: * Excel & CSV query runner (getredash#2478) * Pin python3 image version (getredash#5570) * Fix: Edit Source button disappeared for users without CanEdit perms (getredash#5568) * Fix: Specify the protobuf version (getredash#5608) Plus one additional change exclusive to this branch: * Replace reference to yarn with NPM This happened because we cherry-picked getredash#5570 but did not also incorporate getredash#5541 into V10. Co-authored-by: deecay <deecay@users.noreply.github.com> Co-authored-by: Levko Kravets <levko.ne@gmail.com> Co-authored-by: zoomdot <gninggoon@gmail.com> commit 92e5d78 Author: Jesse <jesse.whitehouse@databricks.com> Date: Thu Jun 17 13:42:07 2021 -0500 Update changelog details for snowflake (getredash#5519) commit 0983e69 Author: Jesse <jesse.whitehouse@databricks.com> Date: Thu Jun 17 12:45:17 2021 -0500 update changelog for v10-beta (getredash#5517) commit dec8879 Author: Jesse <jesse.whitehouse@databricks.com> Date: Tue Jun 15 15:04:36 2021 -0500 Fix: pagination is broken on the dashboard list page (getredash#5516) * Add test that reproduces issue getredash#5466 * Fix: Duplicate dashboard rows were returned by Dashboard.all() (getredash#5466) commit 64a1d7a Author: Jesse Whitehouse <jesse@whitehouse.dev> Date: Tue Jun 1 11:21:49 2021 -0500 Update version for CircleCI build.
susodapop
pushed a commit
that referenced
this pull request
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The
Dashboard.all()query fetches duplicate rows because of its outer join conditions. This PR adds back a.distinct()construct de-duplicates the resullt set. DISTINCT is called oncreated_atandslugbecause a genericdistinct()fails when comparing the JSON fields.Related Tickets & Documents
Closes #5466
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before
After