-
-
Notifications
You must be signed in to change notification settings - Fork 656
Add asyncio aiohttp transport for raven-python #461
Conversation
I see some errors on Travis like
But the errors definitely are not related to my changes |
@dcramer would you like to include asyncio/aiohttp transport into raven? |
docs/transports/index.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment about tornado is wrong, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@dcramer I've fixed the doc and added more verbose response error handling. Also please describe what should I do with |
@dcramer I've fixed all your notes. |
Thanks! |
Add asyncio aiohttp transport for raven-python
Thank you too! |
@dcramer when do you want to publish release with aiohttp transport? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asvetlov, there is a typo -- aiohttp.TCPConnector
missing loop
argument.
Also family
argument in __init__
never used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@popravich see #480
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
The transport sends sentry messages asynchronously in separate asyncio task.
But it requires started asyncio event loop.
Works on Python 3.3+
Dependencies: tulip (for Python 3.3) and aiohttp library.