Skip to content

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Mar 5, 2018

This fixes an issue where if an error occurs in a module, we do not send the event to Sentry because it's always a RCTFatalException.
This makes the check more explicit.
Also updated CocoaPods docs.

@HazAT HazAT self-assigned this Mar 5, 2018
@HazAT HazAT requested a review from mitsuhiko March 5, 2018 19:24
@HazAT HazAT requested a review from jan-auer March 6, 2018 07:52
@HazAT HazAT mentioned this pull request Mar 6, 2018
@HazAT HazAT merged commit 8b121c3 into master Mar 6, 2018
@HazAT HazAT deleted the fix/rctfatal branch March 6, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants