Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replays): Add video entry to DataCategory enum #3847

Merged
merged 10 commits into from
Jul 23, 2024

Conversation

cmanallen
Copy link
Member

During the beta period we're not emitting accepted replay outcomes for mobile replays (to prevent customer's from being billed). Tracking usage through Looker is difficult without this data. We want to emit a non-billed outcome in our consumer for tracking purposes. This category is assumed to be temporary.

Related: https://github.com/getsentry/team-replay/issues/452

Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the docs right below your change:

//
// IMPORTANT: After adding a new entry to DataCategory, go to the `relay-cabi` subfolder and run
// `make header` to regenerate the C-binding. This allows using the data category from Python.
// Rerun this step every time the **code name** of the variant is updated.
//
/// Any other data category not known by this Relay.

@Dav1dde
Copy link
Member

Dav1dde commented Jul 22, 2024

Ah, I forgot before. Please also add a changelog entry to py/CHANGELOG.md since this will be a change in the Python lib and Sentry (or consumers) will depend on that change.

@cmanallen
Copy link
Member Author

@Dav1dde Any ideas?

(.venv) ➜  relay-cabi git:(cmanallen/replays-add-video-data-category) ✗ make header
cbindgen -c cbindgen.toml . -o include/relay.h
make: cbindgen: No such file or directory
make: *** [include/relay.h] Error 1
(.venv) ➜  relay-cabi git:(cmanallen/replays-add-video-data-category) ✗ ls
Cargo.toml    Makefile      cbindgen.toml include       src
(.venv) ➜  relay-cabi git:(cmanallen/replays-add-video-data-category) ✗ ls include
relay.h

@cmanallen
Copy link
Member Author

cmanallen commented Jul 22, 2024

@Dav1dde Oh, I don't think I have cbindgen installed. Let's see if that fixes it. EDIT: It did.

relay-quotas/src/quota.rs Outdated Show resolved Hide resolved
@cmanallen cmanallen merged commit a2ccf08 into master Jul 23, 2024
23 checks passed
@cmanallen cmanallen deleted the cmanallen/replays-add-video-data-category branch July 23, 2024 16:40
cmanallen added a commit to getsentry/sentry that referenced this pull request Jul 29, 2024
Emitting replay video outcome for tracking purposes.

Closes: getsentry/team-replay#452
Related: getsentry/relay#3847
cmanallen added a commit that referenced this pull request Aug 6, 2024
Right now the outcomes are going to the metric second category instead
of replay-video.

#skip-changelog

Related: #3847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants