-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replays): Add video entry to DataCategory enum #3847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the docs right below your change:
relay/relay-base-schema/src/data_category.rs
Lines 91 to 96 in 93144ee
// | |
// IMPORTANT: After adding a new entry to DataCategory, go to the `relay-cabi` subfolder and run | |
// `make header` to regenerate the C-binding. This allows using the data category from Python. | |
// Rerun this step every time the **code name** of the variant is updated. | |
// | |
/// Any other data category not known by this Relay. |
Ah, I forgot before. Please also add a changelog entry to |
@Dav1dde Any ideas?
|
@Dav1dde Oh, I don't think I have cbindgen installed. Let's see if that fixes it. EDIT: It did. |
block
Emitting replay video outcome for tracking purposes. Closes: getsentry/team-replay#452 Related: getsentry/relay#3847
Right now the outcomes are going to the metric second category instead of replay-video. #skip-changelog Related: #3847
During the beta period we're not emitting accepted replay outcomes for mobile replays (to prevent customer's from being billed). Tracking usage through Looker is difficult without this data. We want to emit a non-billed outcome in our consumer for tracking purposes. This category is assumed to be temporary.
Related: https://github.com/getsentry/team-replay/issues/452