feat(replays): Emit mobile replay outcomes #74649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
michellewzhang
approved these changes
Jul 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74649 +/- ##
===========================================
+ Coverage 47.46% 78.14% +30.67%
===========================================
Files 6747 6727 -20
Lines 301197 299409 -1788
Branches 51837 51565 -272
===========================================
+ Hits 142978 233965 +90987
+ Misses 152988 59120 -93868
- Partials 5231 6324 +1093
|
| if not project.flags.has_replays: | ||
| first_replay_received.send_robust(project=project, sender=Project) | ||
|
|
||
| # Replay videos are not billed for now. |
Contributor
There was a problem hiding this comment.
comment is outdated?
Member
Author
There was a problem hiding this comment.
No this outcome is not billed. We're adding it so the PMs can access the data in looker.
Contributor
There was a problem hiding this comment.
additionally: should there be a test covering this change?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitting replay video outcome for tracking purposes.
Closes: https://github.com/getsentry/team-replay/issues/452
Related: getsentry/relay#3847