ref(crons): Prefer DSN based auth

[kamilogorek]

Replaces #1541 and #1543

[kamilogorek]

@evanpurkhiser feel free to merge it once you test it out

[evanpurkhiser]

Ahh, I was trying to clear it out like this but that wasn't working since even having a blank value was reading it :-)

There must be some logic somewhere that treats empty as None in the new code

[kamilogorek]

Yup, it's here -

sentry-cli/src/config.rs

Lines 407 to 416 in ac6532f

	/// Return the DSN
	pub fn get_dsn(&self) -> Result<Dsn> {
	if let Ok(val) = env::var("SENTRY_DSN") {
	Ok(val.parse()?)
	} else if let Some(val) = self.ini.get_from(Some("auth"), "dsn") {
	Ok(val.parse()?)
	} else {
	bail!("No DSN provided");
	}
	}

Empty string fails to .parse() as Dsn type.

[evanpurkhiser]

Nice

[mattjohnsonpint]

Some explanation would be useful. What is "DSN based auth"? And does it only apply to certain Sentry CLI operations, or anything? For example, does this mean I could use a DSN instead of an auth token to upload debug info files? Thanks.

[mattjohnsonpint]

... I'm guessing not. But at any rate, it DSN based auth it a thing for Sentry CLI, should it be mentioned in docs, such as in Configuration and Authentication? Thanks.

[kamilogorek]

DSN auth is not too accurate tbh. It's the same "auth" as you'd do with using send-event or send-envelope. Which is more of an "identification" than "authorization".