feat: Allow for ignoring missing commits in set-commit #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
force-pushed
the
ignore-missing-commits
branch
from
e9fb29c
to
b971ac8
Compare
kamilogorek
force-pushed
the
ignore-missing-commits
branch
from
9e6636c
to
7a4feab
Compare
NisanthanNanthakumar
approved these changes
May 25, 2021
There was a problem hiding this comment.
@kamilogorek Looks good to me! I think we should add docs for this flag. Since this is primarily an issue that affects the --local flow, I think https://docs.sentry.io/product/cli/releases/#alternatively-without-a-repository-integration is a good place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could go with the more complex route of fetching all N releases and use their previous commits one by one, until we find a working one, however:
get_previous_release_with_commitsthat we use currently, is a very specific/previous-with-commitsendpoint that returns only a single releaseThis change will allow us to be more "generous" for malformed repositories and it will still work fine with
initial-depthoption. Tested it on production already and works as expected.Fixes: #792
Fixes #945
Fixes: #956
Fixes: EmberExperts/ember-cli-deploy-sentry-cli#10