Skip to content

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Sep 17, 2025

📜 Description

Remove unused crash report fields binary_cpu_type and binary_cpu_subtype so we can also remove the call to _dyld_get_image_header, which lead to app launch hangs for a customer. Still, these
fields might be useful and we can readd them with GH-6180.

💡 Motivation and Context

Quick fix for #6180

💚 How did you test it?

  1. Unit tests are still green. We have plenty of crash reports in our tests that have the binary_cpu_subtype and binary_cpu_type, so we test that if previous reports contain this info, we handle it correctly.
  2. Manually crashing with a simulator from main and then relaunching an app with a simulator on this branch: https://sentry-sdks.sentry.io/issues/6774282031/events/1e11ac3ac75d44f89c49838f5ad1f7af/?project=5428557
  3. Manually crashing and relaunching an app with a simulator, all on this branch: https://sentry-sdks.sentry.io/issues/6774282031/events/69ca9b30a0ea4252885f62ce80a6090c/?project=5428557

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Remove unused crash report fields binary_cpu_type and binary_cpu_subtype
so we can also remove the call to _dyld_get_image_header, which lead to
app launch hangs for a customer. Still, these
fields might be useful and we can readd them with GH-6180.
Copy link

codecov bot commented Sep 17, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3959 1 3958 22
View the top 2 failed test(s) by shortest run time
iOS_Swift_UITests.LaunchUITests::testBreadcrumbData
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UITestHelpers.swift:5 - Failed to get matching snapshots: Timed out while evaluating UI query.
iOS_Swift_UITests.LaunchUITests::testCheckSlowAndFrozenFrames
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UITestHelpers.swift:5 - Failed to get matching snapshots: Timed out while evaluating UI query.
View the full list of 1 ❄️ flaky tests
SentryTests.SentrySDKInternalTests::testResumeAndPauseAppHangTracking

Flake rate in main: 14.00% (Passed 43 times, Failed 7 times)

Stack Traces | 0s run time
.../Tests/SentryTests/SentrySDKInternalTests.swift:632 - XCTAssertEqual failed: ("1") is not equal to ("0")

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Sep 17, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.67 ms 1249.11 ms 21.44 ms
Size 23.75 KiB 974.89 KiB 951.15 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
07d7e83 1211.71 ms 1240.08 ms 28.37 ms
42cfd79 1222.13 ms 1244.23 ms 22.10 ms
50a9ff7 1221.43 ms 1238.07 ms 16.64 ms
073562b 1232.63 ms 1259.88 ms 27.24 ms
f262e10 1226.88 ms 1250.39 ms 23.51 ms
5db87fa 1218.88 ms 1251.53 ms 32.65 ms
c30e401 1218.71 ms 1243.73 ms 25.02 ms
e36128b 1213.04 ms 1248.60 ms 35.56 ms
891fd1d 1220.02 ms 1227.60 ms 7.57 ms
9e0030e 1222.78 ms 1242.23 ms 19.45 ms

App size

Revision Plain With Sentry Diff
07d7e83 23.75 KiB 913.27 KiB 889.52 KiB
42cfd79 23.75 KiB 880.20 KiB 856.45 KiB
50a9ff7 23.75 KiB 913.63 KiB 889.89 KiB
073562b 23.75 KiB 927.06 KiB 903.31 KiB
f262e10 23.75 KiB 913.62 KiB 889.87 KiB
5db87fa 23.75 KiB 926.65 KiB 902.90 KiB
c30e401 23.74 KiB 971.70 KiB 947.96 KiB
e36128b 23.75 KiB 963.19 KiB 939.44 KiB
891fd1d 23.75 KiB 919.92 KiB 896.17 KiB
9e0030e 23.75 KiB 893.72 KiB 869.97 KiB

Previous results on branch: fix/app-launch-hang

Startup times

Revision Plain With Sentry Diff
140f855 1219.12 ms 1241.04 ms 21.92 ms

App size

Revision Plain With Sentry Diff
140f855 23.75 KiB 974.91 KiB 951.17 KiB

@philipphofmann philipphofmann merged commit ea12acf into main Sep 17, 2025
199 of 207 checks passed
@philipphofmann philipphofmann deleted the fix/app-launch-hang branch September 17, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants