Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Sep 19, 2025

Fixes #6198 by removing the objc selectors in favor of pure Swift

Closes #6212

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.705%. Comparing base (a4c5ddc) to head (5a7fffc).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #6211   +/-   ##
=========================================
  Coverage   86.705%   86.705%           
=========================================
  Files          436       435    -1     
  Lines        37090     37090           
  Branches     17363     17366    +3     
=========================================
  Hits         32159     32159           
+ Misses        4889      4888    -1     
- Partials        42        43    +1     
Files with missing lines Coverage Δ
...grations/SessionReplay/SentryReplayRecording.swift 100.000% <100.000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c5ddc...5a7fffc. Read the comment docs.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.96 ms 1249.96 ms 28.00 ms
Size 23.75 KiB 976.63 KiB 952.88 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
162cd7f 1230.59 ms 1256.76 ms 26.16 ms
30f4e4c 1213.21 ms 1250.29 ms 37.08 ms
65f8d2e 1221.15 ms 1243.96 ms 22.81 ms
331dad6 1210.40 ms 1242.06 ms 31.67 ms
bc0a04c 1226.83 ms 1255.04 ms 28.21 ms
480185d 1220.50 ms 1246.04 ms 25.54 ms
2a07609 1207.79 ms 1233.77 ms 25.98 ms
e98d6f5 1228.51 ms 1258.85 ms 30.34 ms
83bb978 1238.33 ms 1260.04 ms 21.71 ms
3ec47ae 1229.71 ms 1257.13 ms 27.41 ms

App size

Revision Plain With Sentry Diff
162cd7f 23.75 KiB 908.39 KiB 884.64 KiB
30f4e4c 23.75 KiB 879.24 KiB 855.50 KiB
65f8d2e 23.74 KiB 872.67 KiB 848.93 KiB
331dad6 23.75 KiB 928.12 KiB 904.37 KiB
bc0a04c 23.75 KiB 933.32 KiB 909.57 KiB
480185d 23.75 KiB 913.42 KiB 889.67 KiB
2a07609 23.75 KiB 912.78 KiB 889.03 KiB
e98d6f5 23.75 KiB 933.03 KiB 909.28 KiB
83bb978 23.75 KiB 920.64 KiB 896.89 KiB
3ec47ae 23.75 KiB 919.91 KiB 896.16 KiB

@noahsmartin noahsmartin merged commit b074ba9 into main Sep 19, 2025
193 of 198 checks passed
@noahsmartin noahsmartin deleted the replayRecordingSerializationSwift branch September 19, 2025 15:33
@philprime philprime mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Remove objc from session replay recording methods Sentry iOS SDK Session Replay Crash on iOS 26 Beta
2 participants