Mark transaction as internal_error in case of unhandled errors
#1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1218 +/- ##
=========================================
Coverage ? 89.04%
=========================================
Files ? 111
Lines ? 3487
Branches ? 0
=========================================
Hits ? 3105
Misses ? 382
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marandaneto
commented
Jan 11, 2023
|
|
||
| ## 7.0.0-alpha.1 | ||
|
|
||
| ### Various fixes & improvements |
There was a problem hiding this comment.
Just fixing the changelog.
marandaneto
commented
Jan 11, 2023
| ); | ||
| } | ||
| /// Parse and raise an event out of the Isolate error. | ||
| @visibleForTesting |
There was a problem hiding this comment.
Just moved from a standalone function to inside of the class.
marandaneto
commented
Jan 11, 2023
Comment on lines
+70
to
+74
| // marks the span status if none to `internal_error` in case there's an | ||
| // unhandled error | ||
| hub.configureScope((scope) => { | ||
| scope.span?.status ??= const SpanStatus.internalError(), | ||
| }); |
There was a problem hiding this comment.
That's the added code.
marandaneto
commented
Jan 11, 2023
| @@ -20,6 +22,40 @@ class RunZonedGuardedIntegration extends Integration { | |||
| /// Needed to check if we somehow caused a `print()` recursion | |||
| bool _isPrinting = false; | |||
|
|
|||
| @visibleForTesting | |||
There was a problem hiding this comment.
Just moved to the class, to be tested.
marandaneto
commented
Jan 11, 2023
Comment on lines
+50
to
+54
| // marks the span status if none to `internal_error` in case there's an | ||
| // unhandled error | ||
| hub.configureScope((scope) => { | ||
| scope.span?.status ??= const SpanStatus.internalError(), | ||
| }); |
marandaneto
commented
Jan 11, 2023
| @@ -9,134 +9,170 @@ import '../mocks.mocks.dart'; | |||
| import 'mock_platform_dispatcher.dart'; | |||
|
|
|||
| void main() { | |||
| TestWidgetsFlutterBinding.ensureInitialized(); | |||
| group(OnErrorIntegration, () { | |||
There was a problem hiding this comment.
Just moved within the group
marandaneto
commented
Jan 11, 2023
| final throwableMechanism = event.throwableMechanism as ThrowableMechanism; | ||
| expect(throwableMechanism.mechanism.handled, true); | ||
| }); | ||
| test('marks transaction as internal error if no status', () async { |
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #1182
💚 How did you test it?
📝 Checklist
🔮 Next steps