Only Spans Docs #11731
Only Spans Docs #11731
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| The `parentSampleRate` is a propagated value inside the baggage, using key `sentry-sample_rand`. | ||
| The value stems from a truly random number between 0 and 1, generated when a new trace is started. If the SDK does not receive such a number in an incoming trace, a new, truly random number between 0 and 1 is generated. | ||
|
|
||
| In the following cases, the SDK must compare sample rates against this `parentSampleRate` instead of `math.random()`: |
There was a problem hiding this comment.
This should be:
| In the following cases, the SDK must compare sample rates against this `parentSampleRate` instead of `math.random()`: | |
| In the following cases, the SDK must compare sample rates against this `sentry-sample_rand` instead of `math.random()`: |
Should we rephrase this, that the SDK always compares with the sample_rand value, especially the two places? In reality, the SDK should never create a new random number during sampling, only ever when initializing a trace that doesn't have the random value attached yet.
There was a problem hiding this comment.
Yep, I'll re-phrase the entire paragraph, as I'm not happy with the current state.
| ``` | ||
|
|
||
| The `parentSampleRate` is a propagated value inside the baggage, using key `sentry-sample_rand`. | ||
| The value stems from a truly random number between 0 and 1, generated when a new trace is started. If the SDK does not receive such a number in an incoming trace, a new, truly random number between 0 and 1 is generated. |
There was a problem hiding this comment.
nit: Should we clarify that the value must be placed in baggage and propagated from now on?
There was a problem hiding this comment.
See above, "The parentSampleRate is a propagated value inside the baggage, using key sentry-sample_rand."
|
|
||
| ## Parent Sampling Origins | ||
|
|
||
| If the SDK can parse an org ID from the configured DSN, this value must be propagated as a baggage entry with the key `sentry-org`. Given a DSN of `https://1234@o1.ingest.us.sentry.io/1`, the org ID is 1, based on `o1`. |
There was a problem hiding this comment.
This doesn't cover self-hosted, most organizations there will have org ID 1. If we're OK with this restriction, I think we should write this down. If we're not OK with this restriction, we'd need to add an additional identifier from the instance, though I currently don't have a good idea where to get this from.
There was a problem hiding this comment.
I'll add this limitation for self-hosted and refer to using the org option in such cases.
Co-authored-by: Jan Michael Auer <mail@jauer.org>
Co-authored-by: Jan Michael Auer <mail@jauer.org>
| - The APIs are optimized for trace completeness | ||
| - The APIs are optimized for conclusive sampling decisions | ||
|
|
||
| ## Sample root spans with `tracesSampleRate` & `tracesSampler` |
There was a problem hiding this comment.
Before this gets merged, I would love it if this section contained one or two paragraphs on the goals of the API & behavior. As it stands, this reads very much like a "do this" with no context whatsoever but I assume this is due to it being WIP.
4 participants
No description provided.