-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(sdks): Propagated Sampling Rates & Strict Trace Propagation #11912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e79e54a
Propagated Sampling Rates
cleptric c93add7
Clarify org setting
cleptric 2e30a1c
Apply wording suggestions from code review
stephanie-anderson 36711c7
fix: DSC invariant
jan-auer ad45636
More rules
jan-auer 2f00a67
Apply suggestions from code review
cleptric 52f3343
Cleanup
cleptric 420d652
Add new strictTracePropagation behaviour
cleptric 4171e84
Cleanup
cleptric 44903cb
Apply suggestions from code review
cleptric 7364dfb
Wording
cleptric e4d9054
Wording
cleptric File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why deprecate this and not just keep treating
true
as1.0
andfalse
as0.0
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the benefit of doing so?
On first glance, I see a couple of downsides in having booleans in the API:
1.0
(100%) for extrapolation are inherently clear, but forreturn True
not so much. My expectation would be that we "inherit" the parent extrapolation factor, but in reality we apply a hidden 100% sample rate.