Skip to content

Remove escape characters from hompage title and desc #14207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025

Conversation

coolguyzone
Copy link
Contributor

@coolguyzone coolguyzone commented Jun 30, 2025

DESCRIBE YOUR PR

Removing unnecessary escape characters that are showing up in SERP.

To verify go to https://sentry-docs-git-fix-title-ampersand.sentry.dev/ and confirm that when you hover over the tab, you see the ampersand in the title and not the escaped chars you'll see on the production site.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jun 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 9:16pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 9:16pm

Copy link

codecov bot commented Jun 30, 2025

Bundle Report

Changes will increase total bundle size by 860.2kB (4.07%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.8MB 860.2kB (7.87%) ⬆️
sentry-docs-client-array-push 9.8MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 873.24kB -0.0%
static/chunks/7750-*.js -3 bytes 415.85kB -0.0%
static/ZbJuY0FMv2xs1KTNsi4XE/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/ZbJuY0FMv2xs1KTNsi4XE/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/5eoELqmEKgStCV6gBaZeB/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/5eoELqmEKgStCV6gBaZeB/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 973.36kB -0.0%
9523.js -3 bytes 949.31kB -0.0%
../app/[[...path]]/page.js.nft.json 286.74kB 691.02kB 70.93% ⚠️
../app/platform-redirect/page.js.nft.json 286.74kB 690.94kB 70.94% ⚠️
../app/sitemap.xml/route.js.nft.json 286.74kB 688.91kB 71.3% ⚠️
../app/[[...path]]/page.js -10 bytes 591.6kB -0.0%

Files in ../app/[[...path]]/page.js:

  • ./app/[[...path]]/page.tsx → Total Size: 10.99kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] -10 bytes 3.14MB -0.0%

Copy link
Member

@mrduncan mrduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment, lgtm otherwise

Co-authored-by: Matt Duncan <14761+mrduncan@users.noreply.github.com>
@coolguyzone coolguyzone enabled auto-merge (squash) June 30, 2025 20:58
@coolguyzone coolguyzone merged commit d859b85 into master Jun 30, 2025
15 checks passed
@coolguyzone coolguyzone deleted the fix-title-ampersand branch June 30, 2025 21:16
bitsandfoxes pushed a commit that referenced this pull request Jul 3, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR
Removing unnecessary escape characters that are showing up in SERP.

To verify go to https://sentry-docs-git-fix-title-ampersand.sentry.dev/
and confirm that when you hover over the tab, you see the ampersand in
the title and not the escaped chars you'll see on the production site.


## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [ ] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

## LEGAL BOILERPLATE

<!-- Sentry employees and contractors can delete or ignore this section.
-->

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

## EXTRA RESOURCES

- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)

---------

Co-authored-by: Alex Krawiec <alex.krawiec@R7J1Y747QQ.local>
Co-authored-by: Matt Duncan <14761+mrduncan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants