-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(examples): Python SDK Metric Span tracing examples set data indiv… #14360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…idually rather than using a dict Examples for metric spans in the Python SDK set data for spans using a dictionary, which does not actually work. Change this to set the span_data indivually instead. Fixes GH-14359
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 1.35kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See one typo before merging, otherwise looks good. Thanks for fixing!
}) | ||
span.set_data("memory.heap_used", 1024000) | ||
span.set_data("queue.length", 15) | ||
span.set_data("processing.duration_ms", 127s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
span.set_data("processing.duration_ms", 127s) | |
span.set_data("processing.duration_ms", 127) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that, fixed it!
#14360) Examples for metric spans in the Python SDK set data for spans using a dictionary, which does not work when tested locally. Change this to set the span_data indivually instead. Fixes GH-14359 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Examples for metric spans in the Python SDK set data for spans using a dictionary, which does not work when tested locally. Change this to set the span_data indivually instead.
Fixes GH-14359
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
EXTRA RESOURCES