-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(js): Update Remix on Cloudflare quick start guide #14873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will decrease total bundle size by 111.78kB (-0.48%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
…ick-start/cloudflare-remix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
platform-includes/getting-started-complete/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-complete/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be importing Sentry from @sentry/remix/cloudflare
, not to break builds on Cloudflare.
@inventarSarah, do you mind if I push updates to this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛳️
@onurtemizkan please go ahead and just push on the branch 👍 |
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
DESCRIBE YOUR PR
Updated the Remix on Cloudflare quick start guide to follow our template.
The main Remix quick start guide (manual setup) page and the Remix on Cloudflare quick start guide page share the same file/content. We did this for Nuxt/SvelteKit on Cloudflare too -> you can read more about it #14679
Closes: #14845
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES
Note
Unifies Remix and Remix on Cloudflare docs by introducing a shared getting-started include and updating both pages to reference it.
platform-includes/getting-started-complete/javascript.remix.mdx
with full setup (client, server, Cloudflare middleware, source maps, verification, next steps).docs/platforms/javascript/guides/remix/manual-setup.mdx
withgetting-started-complete
include.docs/platforms/javascript/guides/cloudflare/frameworks/remix.mdx
with the same include and update description.Written by Cursor Bugbot for commit eed0186. This will update automatically on new commits. Configure here.