Skip to content

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad self-assigned this Sep 11, 2025
Copy link

linear bot commented Sep 11, 2025

Copy link

vercel bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Sep 26, 2025 3:47pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Sep 26, 2025 3:47pm

Copy link

codecov bot commented Sep 11, 2025

Bundle Report

Changes will increase total bundle size by 125 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.13MB 207 bytes (0.0%) ⬆️
sentry-docs-server-cjs 12.86MB -82 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json -50 bytes 826.04kB -0.01%
../app/platform-redirect/page.js.nft.json -50 bytes 825.95kB -0.01%
../app/sitemap.xml/route.js.nft.json -50 bytes 823.18kB -0.01%
4873.js 77 bytes 91.22kB 0.08%

Files in 4873.js:

  • ./src/components/codeContext.tsx → Total Size: 9.06kB

  • ./src/components/codeContext.tsx → Total Size: 2.47kB

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/chunks/4145-*.js 213 bytes 50.66kB 0.42%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/vFIZmM2cpc80nL65NImcA/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/vFIZmM2cpc80nL65NImcA/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/6H2PjzJc6qUAxAMQnrCA1/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/6H2PjzJc6qUAxAMQnrCA1/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/4145-*.js:

  • ./src/components/codeContext.tsx → Total Size: 9.83kB

@AbhiPrasad AbhiPrasad marked this pull request as ready for review September 25, 2025 15:47
@AbhiPrasad AbhiPrasad requested a review from mjq September 25, 2025 15:47
Comment on lines 82 to 83
processors: [new BatchRecordProcessor(logExporter)],
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The OTLP logs documentation example uses BatchRecordProcessor, but the correct imported class is BatchLogRecordProcessor, which will cause a runtime error.
  • Description: The code example for setting up OpenTelemetry logs imports the class BatchLogRecordProcessor but then attempts to instantiate BatchRecordProcessor. This mismatch will cause a ReferenceError: BatchRecordProcessor is not defined when a user copies and runs the provided code. This prevents the code example from working and will cause an immediate crash when trying to initialize the LoggerProvider.

  • Suggested fix: In the LoggerProvider instantiation, change the incorrect class name BatchRecordProcessor to the correct, imported class name BatchLogRecordProcessor.
    severity: 0.7, confidence: 0.98

Did we get this right? 👍 / 👎 to inform future reviews.


If you have an existing OpenTelemetry log instrumentation, you can configure your OpenTelemetry exporter to send logs to Sentry directly. Sentry's OTLP ingestion logs endpoint has the following known limitations:

- Array attributes are partially supported. We ingest and display array attributes, but they cannot be searched, filtered, or aggregated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect this list of limitations to grow? If not, I'd recommend not displaying this in a list format.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the list will grow, so I'll keep it like this for now.

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) September 26, 2025 14:45
cursor[bot]

This comment was marked as outdated.

@AbhiPrasad AbhiPrasad merged commit 7b83d92 into master Sep 26, 2025
15 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-otel-logs-docs branch September 26, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants